src/charm_state.py:335

• reconcile_interval validation is inconsistent: the code rejects values < 2, but the logged/raised messages say the value must be ��>= 1. Decide whether 1-minute intervals are allowed (change the check to < 1) or keep the minimum at 2 and update the messages accordingly, so users get correct guidance.
  charmcraft.yaml:164
• max-total-virtual-machines still documents behavior tied to MongoDB/reactive mode (integrated with MongoDB, reactive mode, etc.), but this PR removes the MongoDB relation and reactive spawning. Update this option’s description to reflect the new semantics (or remove the MongoDB/reactive references) to avoid misleading operators.

      default: 0
      description: >-
        If the github-runner charm is integrated with MongoDB, the reactive mode will not spawn
        new virtual machines if there are max-total-virtual-machines of more virtual machines
        managed by the charm.

terraform/product/outputs.tf:12

• This module drops the reactive-specific Terraform output, but terraform/charm/outputs.tf still advertises mongodb_client = "mongodb" in its requires output. That output is now stale given the MongoDB relation removal, so it should be updated to avoid consumers attempting to wire a non-existent integration.

github-runner-manager/src/github_runner_manager/configuration/base.py:66

• reconcile_interval is currently an unconstrained int. If a user sets it to 0, the pressure reconciler’s reconcile loop will effectively busy-spin (Event.wait(0) returns immediately), causing high CPU usage. Please enforce a safe minimum (e.g., Field(gt=0) / Field(ge=1)) and/or validate it when loading config so invalid values fail fast with a clear error.

    planner_url: Optional[AnyHttpUrl] = None
    planner_token: Optional[str] = None
    reconcile_interval: int

github-runner-manager/src/github_runner_manager/metrics/events.py:143

• Reconciliation.expected_runners is still typed as int | None, but the updated docstring now states it is always present. With reactive mode removed, either tighten the field type to int (and rely on validation) or update the docstring to reflect that None is still allowed (and why).

        expected_runners: The expected number of runners.
        duration: The duration of the reconciliation in seconds.
    """

    flavor: str
    crashed_runners: int
    idle_runners: int
    active_runners: int
    expected_runners: int | None
    duration: NonNegativeFloat